OpenWrt – Diff between revs 2 and 3

Subversion Repositories:

?pathlinks?

Rev 2 – Details – Blame – Last modification – View Log

Only display areas with differences – Ignore whitespace

-From 6af0148a38b23ba761905f98a7211fab986033ce Mon Sep 17 00:00:00 2001
+From 25de6430219d3f3698d709c10358fbea17b24cf1 Mon Sep 17 00:00:00 2001
 From: Michael Heimpold <mhei@heimpold.de>
-Date: Thu, 13 Sep 2018 21:40:19 +0200
+Date: Fri, 21 Apr 2017 11:08:19 +0200
 Subject: [PATCH] arm: mxs: add support for I2SE's Duckbill boards
 The Duckbill devices are small, pen-drive sized boards based on
 NXP's i.MX28 SoC. While the initial variants (Duckbill series) were
 equipped with a micro SD card slot only, the latest generation
 (Duckbill 2 series) have an additional internal eMMC onboard.
-Both device generations consist of four "family members":
+Both device generations consists of four "family members":
 - Duckbill/Duckbill 2: generic board, intended to be used as
   baseboard for custom designs and/or as development board
 - Duckbill EnOcean/Duckbill 2 EnOcean: come with an EnOcean
   daugther board equipped with the popular TCM310 module
 - Duckbill 485/Duckbill 2 485: as the name implies, these
   devices are intended to be used as Ethernet - RS485 converters
 - Duckbill SPI/Duckbill 2 SPI: not sold separately, but used
   in I2SE's development kits for Green PHY HomePlug Powerline
   communication
 Signed-off-by: Michael Heimpold <mhei@heimpold.de>
 Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
 ---
- arch/arm/mach-imx/mxs/Kconfig   |   5 +
+ arch/arm/Kconfig                |   9 +-
  board/i2se/duckbill/Kconfig     |  15 +++
  board/i2se/duckbill/MAINTAINERS |   6 ++
- board/i2se/duckbill/Makefile    |  10 ++
+ board/i2se/duckbill/Makefile    |  12 +++
- board/i2se/duckbill/duckbill.c  | 186 ++++++++++++++++++++++++++++++++
+ board/i2se/duckbill/duckbill.c  | 181 ++++++++++++++++++++++++++++++++++++
- board/i2se/duckbill/iomux.c     | 156 +++++++++++++++++++++++++++
+ board/i2se/duckbill/iomux.c     | 157 +++++++++++++++++++++++++++++++
- configs/duckbill_defconfig      |  38 +++++++
+ configs/duckbill_defconfig      |  31 +++++++
- include/configs/duckbill.h      | 179 ++++++++++++++++++++++++++++++
+ include/configs/duckbill.h      | 199 ++++++++++++++++++++++++++++++++++++++++
-files changed, 595 insertions(+)
+files changed, 609 insertions(+), 1 deletion(-)
  create mode 100644 board/i2se/duckbill/Kconfig
  create mode 100644 board/i2se/duckbill/MAINTAINERS
  create mode 100644 board/i2se/duckbill/Makefile
  create mode 100644 board/i2se/duckbill/duckbill.c
  create mode 100644 board/i2se/duckbill/iomux.c
  create mode 100644 configs/duckbill_defconfig
  create mode 100644 include/configs/duckbill.h
-diff --git a/arch/arm/mach-imx/mxs/Kconfig b/arch/arm/mach-imx/mxs/Kconfig
-index 68072d5a1f..82aaa3ef76 100644
---- a/arch/arm/mach-imx/mxs/Kconfig
+--- a/arch/arm/Kconfig
-+++ b/arch/arm/mach-imx/mxs/Kconfig
++++ b/arch/arm/Kconfig
-@@ -50,6 +50,10 @@ config TARGET_APX4DEVKIT
+@@ -373,6 +373,12 @@ config TARGET_MX28EVK
- config TARGET_BG0900
+ 	select SUPPORT_SPL
- 	bool "Support bg0900"
+ 	select BOARD_EARLY_INIT_F
 +config TARGET_DUCKBILL
 +	bool "Support duckbill"
++	select CPU_ARM926EJS
++	select SUPPORT_SPL
 +	select BOARD_EARLY_INIT_F
++
- config TARGET_MX28EVK
+ config TARGET_MX23_OLINUXINO
- 	bool "Support mx28evk"
+ 	bool "Support mx23_olinuxino"
- 	select BOARD_EARLY_INIT_F
+ 	select CPU_ARM926EJS
-@@ -67,6 +71,7 @@ config SYS_SOC
+@@ -1250,6 +1256,7 @@ source "board/gumstix/pepper/Kconfig"
+ source "board/h2200/Kconfig"
- source "board/bluegiga/apx4devkit/Kconfig"
+ source "board/hisilicon/hikey/Kconfig"
- source "board/freescale/mx28evk/Kconfig"
+ source "board/hisilicon/poplar/Kconfig"
 +source "board/i2se/duckbill/Kconfig"
- source "board/ppcag/bg0900/Kconfig"
+ source "board/imx31_phycore/Kconfig"
- source "board/schulercontrol/sc_sps_1/Kconfig"
+ source "board/isee/igep003x/Kconfig"
- source "board/technologic/ts4600/Kconfig"
+ source "board/olimex/mx23_olinuxino/Kconfig"
-diff --git a/board/i2se/duckbill/Kconfig b/board/i2se/duckbill/Kconfig
+@@ -1279,7 +1286,7 @@ source "arch/arm/Kconfig.debug"
+ endmenu
-new file mode 100644
+ config SPL_LDSCRIPT
+-        default "arch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds" if TARGET_APX4DEVKIT || TARGET_BG0900 || TARGET_M28EVK || TARGET_MX23_OLINUXINO || TARGET_MX23EVK || TARGET_MX28EVK || TARGET_SANSA_FUZE_PLUS || TARGET_SC_SPS_1 || TARGET_TS4600 || TARGET_XFI3
-index 0000000000..98c1e4689f
++        default "arch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds" if TARGET_APX4DEVKIT || TARGET_BG0900 || TARGET_M28EVK || TARGET_MX23_OLINUXINO || TARGET_MX23EVK || TARGET_MX28EVK || TARGET_DUCKBILL || TARGET_SANSA_FUZE_PLUS || TARGET_SC_SPS_1 || TARGET_TS4600 || TARGET_XFI3
+         default "arch/arm/cpu/arm1136/u-boot-spl.lds" if CPU_ARM1136
+ 	default "arch/arm/cpu/armv8/u-boot-spl.lds" if ARM64
 --- /dev/null
 +++ b/board/i2se/duckbill/Kconfig
 @@ -0,0 +1,15 @@
 +if TARGET_DUCKBILL
++
 +config SYS_BOARD
 +	default "duckbill"
++
 +config SYS_VENDOR
 +	default "i2se"
++
 +config SYS_SOC
 +	default "mxs"
++
 +config SYS_CONFIG_NAME
 +	default "duckbill"
++
 +endif
-diff --git a/board/i2se/duckbill/MAINTAINERS b/board/i2se/duckbill/MAINTAINERS
-new file mode 100644
-index 0000000000..5496baa330
 --- /dev/null
 +++ b/board/i2se/duckbill/MAINTAINERS
 @@ -0,0 +1,6 @@
 +I2SE DUCKBILL BOARD
 +M:	Michael Heimpold <mhei@heimpold.de>
 +S:	Maintained
 +F:	board/i2se/duckbill/
 +F:	include/configs/duckbill.h
 +F:	configs/duckbill_defconfig
-diff --git a/board/i2se/duckbill/Makefile b/board/i2se/duckbill/Makefile
-new file mode 100644
-index 0000000000..0079eb413c
 --- /dev/null
 +++ b/board/i2se/duckbill/Makefile
-@@ -0,0 +1,10 @@
+@@ -0,0 +1,12 @@
-+# SPDX-License-Identifier: GPL-2.0+
 +#
-+# (C) Copyright 2014-2019
++# (C) Copyright 2014-2017
 +# Michael Heimpold, mhei@heimpold.de.
++#
++# SPDX-License-Identifier:	GPL-2.0+
++#
++
 +ifndef	CONFIG_SPL_BUILD
 +obj-y	:= duckbill.o
 +else
 +obj-y	:= iomux.o
 +endif
-diff --git a/board/i2se/duckbill/duckbill.c b/board/i2se/duckbill/duckbill.c
-new file mode 100644
-index 0000000000..f93c372611
 --- /dev/null
 +++ b/board/i2se/duckbill/duckbill.c
-@@ -0,0 +1,186 @@
+@@ -0,0 +1,181 @@
-+// SPDX-License-Identifier: GPL-2.0+
 +/*
 + * I2SE Duckbill board
 + *
-+ * (C) Copyright 2014-2019 Michael Heimpold <mhei@heimpold.de>
++ * (C) Copyright 2014-2017 Michael Heimpold <mhei@heimpold.de>
++ *
++ * SPDX-License-Identifier:	GPL-2.0+
 + */
++
 +#include <common.h>
 +#include <asm/gpio.h>
 +#include <asm/io.h>
 +#include <asm/arch/imx-regs.h>
 +#include <asm/arch/iomux-mx28.h>
 +#include <asm/arch/clock.h>
 +#include <asm/arch/sys_proto.h>
 +#include <asm/setup.h>
 +#include <fdt_support.h>
 +#include <linux/mii.h>
 +#include <miiphy.h>
 +#include <netdev.h>
 +#include <errno.h>
 +#include <fuse.h>
++
 +DECLARE_GLOBAL_DATA_PTR;
++
 +static u32 system_rev;
 +static u32 serialno;
++
 +/*
 + * Functions
 + */
 +int board_early_init_f(void)
 +{
 +	/* IO0 clock at 480MHz */
 +	mxs_set_ioclk(MXC_IOCLK0, 480000);
 +	/* IO1 clock at 480MHz */
 +	mxs_set_ioclk(MXC_IOCLK1, 480000);
++
 +	/* SSP0 clock at 96MHz */
 +	mxs_set_sspclk(MXC_SSPCLK0, 96000, 0);
++
 +	return 0;
 +}
++
 +int dram_init(void)
 +{
 +	return mxs_dram_init();
 +}
++
 +int board_init(void)
 +{
 +	/* Adress of boot parameters */
 +	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
++
 +	return 0;
 +}
++
 +#ifdef	CONFIG_CMD_MMC
 +int board_mmc_init(bd_t *bis)
 +{
 +	return mxsmmc_initialize(bis, 0, NULL, NULL);
 +}
 +#endif
++
 +#ifdef	CONFIG_CMD_NET
 +int board_eth_init(bd_t *bis)
 +{
 +	unsigned int reset_gpio;
 +	int ret;
++
 +	ret = cpu_eth_init(bis);
++
 +	if (system_rev == 1)
 +		reset_gpio = MX28_PAD_SSP0_DATA7__GPIO_2_7;
 +	else
 +		reset_gpio = MX28_PAD_GPMI_ALE__GPIO_0_26;
++
 +	/* Reset PHY */
 +	gpio_direction_output(reset_gpio, 0);
 +	udelay(200);
 +	gpio_set_value(reset_gpio, 1);
++
 +	/* give PHY some time to get out of the reset */
 +	udelay(10000);
++
-+	ret = fecmxc_initialize_multi(bis, 0, 0, MXS_ENET0_BASE);
++	ret = fecmxc_initialize(bis);
 +	if (ret) {
 +		puts("FEC MXS: Unable to init FEC\n");
 +		return ret;
 +	}
++
 +	return ret;
 +}
++
 +void mx28_adjust_mac(int dev_id, unsigned char *mac)
 +{
 +	mac[0] = 0x00;
 +	mac[1] = 0x01;
 +	mac[2] = 0x87;
 +}
 +#endif
++
 +#ifdef CONFIG_OF_BOARD_SETUP
 +int ft_board_setup(void *blob, bd_t *bd)
 +{
 +	uint8_t enetaddr[6];
 +	u32 mac = 0;
++
++	enetaddr[0] = 0x00;
++	enetaddr[1] = 0x01;
++	enetaddr[2] = 0x87;
++
 +#ifdef CONFIG_MXS_OCOTP
 +	/* only Duckbill SPI has a MAC for the QCA7k */
 +	fuse_read(0, 1, &mac);
 +#endif
++
 +	if (mac != 0) {
-+		enetaddr[0] = 0x00;
-+		enetaddr[1] = 0x01;
-+		enetaddr[2] = 0x87;
 +		enetaddr[3] = (mac >> 16) & 0xff;
 +		enetaddr[4] = (mac >>  8) & 0xff;
 +		enetaddr[5] =  mac        & 0xff;
++
-+		fdt_find_and_setprop(blob, "spi1/ethernet@0",
++		fdt_find_and_setprop(blob,
++		                     "/apb@80000000/apbh@80000000/ssp@80014000/ethernet@0",
 +		                     "local-mac-address", enetaddr, 6, 1);
 +	}
++
 +	return 0;
 +}
 +#endif
++
 +#ifdef CONFIG_REVISION_TAG
 +u32 get_board_rev(void)
 +{
 +	return system_rev;
 +}
 +#endif
++
 +#ifdef CONFIG_SERIAL_TAG
 +void get_board_serial(struct tag_serialnr *serialnr)
 +{
 +	serialnr->low = serialno;
 +	serialnr->high = 0;
 +}
 +#endif
++
 +int misc_init_r(void)
 +{
 +	unsigned int led_red_gpio;
 +	char *s;
++
 +	/* Board revision detection */
 +	gpio_direction_input(MX28_PAD_LCD_D17__GPIO_1_17);
++
 +	/* MX28_PAD_LCD_D17__GPIO_1_17: v1 = pull-down, v2 = pull-up */
 +	system_rev =
 +		gpio_get_value(MX28_PAD_LCD_D17__GPIO_1_17);
 +	system_rev += 1;
++
-+	/* guess DT blob if not set in environment */
-+	if (!env_get("fdt_file")) {
-+		if (system_rev == 1)
-+			env_set("fdt_file", "imx28-duckbill.dtb");
-+		else
-+			env_set("fdt_file", "imx28-duckbill-2.dtb");
-+	}
-+
 +	/* enable red LED to indicate a running bootloader */
 +	if (system_rev == 1)
 +		led_red_gpio = MX28_PAD_AUART1_RX__GPIO_3_4;
 +	else
 +		led_red_gpio = MX28_PAD_SAIF0_LRCLK__GPIO_3_21;
 +	gpio_direction_output(led_red_gpio, 1);
++
 +	if (system_rev == 1)
 +		puts("Board: I2SE Duckbill\n");
 +	else
 +		puts("Board: I2SE Duckbill 2\n");
++
 +	serialno = env_get_ulong("serial#", 10, 0);
 +	s = env_get("serial#");
 +	if (s && s[0]) {
 +		puts("Serial: ");
 +		puts(s);
 +		putc('\n');
 +	}
++
 +	return 0;
 +}
-diff --git a/board/i2se/duckbill/iomux.c b/board/i2se/duckbill/iomux.c
-new file mode 100644
-index 0000000000..1db3c52c34
 --- /dev/null
 +++ b/board/i2se/duckbill/iomux.c
-@@ -0,0 +1,156 @@
+@@ -0,0 +1,157 @@
-+// SPDX-License-Identifier: GPL-2.0+
 +/*
 + * I2SE Duckbill IOMUX setup
 + *
-+ * Copyright (C) 2013-2019 Michael Heimpold <mhei@heimpold.de>
++ * Copyright (C) 2013-2017 Michael Heimpold <mhei@heimpold.de>
++ *
++ * SPDX-License-Identifier:	GPL-2.0+
 + */
++
 +#include <common.h>
 +#include <config.h>
 +#include <asm/io.h>
 +#include <asm/gpio.h>
 +#include <asm/arch/iomux-mx28.h>
 +#include <asm/arch/imx-regs.h>
 +#include <asm/arch/sys_proto.h>
++
 +#define	MUX_CONFIG_SSP0	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
 +#define	MUX_CONFIG_ENET	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
 +#define	MUX_CONFIG_EMI	(MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
++
 +/* For all revisions */
 +const iomux_cfg_t iomux_setup[] = {
 +	/* DUART */
 +	MX28_PAD_PWM0__DUART_RX,
 +	MX28_PAD_PWM1__DUART_TX,
++
 +	/* eMMC (v2) or SD card (v1) */
 +	MX28_PAD_SSP0_DATA0__SSP0_D0 | MUX_CONFIG_SSP0,
 +	MX28_PAD_SSP0_DATA1__SSP0_D1 | MUX_CONFIG_SSP0,
 +	MX28_PAD_SSP0_DATA2__SSP0_D2 | MUX_CONFIG_SSP0,
 +	MX28_PAD_SSP0_DATA3__SSP0_D3 | MUX_CONFIG_SSP0,
 +	MX28_PAD_SSP0_CMD__SSP0_CMD | MUX_CONFIG_SSP0,
 +	MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT |
 +		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL),
 +	MX28_PAD_SSP0_SCK__SSP0_SCK |
 +		(MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_NOPULL),
++
 +	/* Ethernet */
 +	MX28_PAD_ENET0_MDC__ENET0_MDC | MUX_CONFIG_ENET,
 +	MX28_PAD_ENET0_MDIO__ENET0_MDIO | MUX_CONFIG_ENET,
 +	MX28_PAD_ENET0_RX_EN__ENET0_RX_EN | MUX_CONFIG_ENET,
 +	MX28_PAD_ENET0_TX_EN__ENET0_TX_EN | MUX_CONFIG_ENET,
 +	MX28_PAD_ENET0_RXD0__ENET0_RXD0 | MUX_CONFIG_ENET,
 +	MX28_PAD_ENET0_RXD1__ENET0_RXD1 | MUX_CONFIG_ENET,
 +	MX28_PAD_ENET0_TXD0__ENET0_TXD0 | MUX_CONFIG_ENET,
 +	MX28_PAD_ENET0_TXD1__ENET0_TXD1 | MUX_CONFIG_ENET,
 +	MX28_PAD_ENET_CLK__CLKCTRL_ENET | MUX_CONFIG_ENET,
++
 +	/* EMI */
 +	MX28_PAD_EMI_D00__EMI_DATA0 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D01__EMI_DATA1 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D02__EMI_DATA2 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D03__EMI_DATA3 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D04__EMI_DATA4 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D05__EMI_DATA5 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D06__EMI_DATA6 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D07__EMI_DATA7 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D08__EMI_DATA8 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D09__EMI_DATA9 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D10__EMI_DATA10 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D11__EMI_DATA11 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D12__EMI_DATA12 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D13__EMI_DATA13 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D14__EMI_DATA14 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_D15__EMI_DATA15 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_ODT0__EMI_ODT0 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_DQM0__EMI_DQM0 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_ODT1__EMI_ODT1 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_DQM1__EMI_DQM1 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_DDR_OPEN_FB__EMI_DDR_OPEN_FEEDBACK | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_CLK__EMI_CLK | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_DQS0__EMI_DQS0 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_DQS1__EMI_DQS1 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_DDR_OPEN__EMI_DDR_OPEN | MUX_CONFIG_EMI,
++
 +	MX28_PAD_EMI_A00__EMI_ADDR0 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A01__EMI_ADDR1 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A02__EMI_ADDR2 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A03__EMI_ADDR3 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A04__EMI_ADDR4 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A05__EMI_ADDR5 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A06__EMI_ADDR6 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A07__EMI_ADDR7 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A08__EMI_ADDR8 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A09__EMI_ADDR9 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A10__EMI_ADDR10 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A11__EMI_ADDR11 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A12__EMI_ADDR12 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A13__EMI_ADDR13 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_A14__EMI_ADDR14 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_BA0__EMI_BA0 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_BA1__EMI_BA1 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_BA2__EMI_BA2 | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_CASN__EMI_CASN | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_RASN__EMI_RASN | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_WEN__EMI_WEN | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_CE0N__EMI_CE0N | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_CE1N__EMI_CE1N | MUX_CONFIG_EMI,
 +	MX28_PAD_EMI_CKE__EMI_CKE | MUX_CONFIG_EMI,
++
 +	/* Revision pin(s) */
 +	MX28_PAD_LCD_D17__GPIO_1_17,
 +};
++
 +/* For revision 1 only */
 +const iomux_cfg_t iomux_setup_v1[] = {
 +	/* PHY reset */
 +	MX28_PAD_SSP0_DATA7__GPIO_2_7 |
 +		(MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
++
 +	/* LEDs */
 +	MX28_PAD_AUART1_RX__GPIO_3_4,
 +	MX28_PAD_AUART1_TX__GPIO_3_5,
 +};
++
 +/* For revision 2 only */
 +const iomux_cfg_t iomux_setup_v2[] = {
 +	/* eMMC (v2) */
 +	MX28_PAD_SSP0_DATA4__SSP0_D4 | MUX_CONFIG_SSP0,
 +	MX28_PAD_SSP0_DATA5__SSP0_D5 | MUX_CONFIG_SSP0,
 +	MX28_PAD_SSP0_DATA6__SSP0_D6 | MUX_CONFIG_SSP0,
 +	MX28_PAD_SSP0_DATA7__SSP0_D7 | MUX_CONFIG_SSP0,
++
 +	/* PHY reset */
 +	MX28_PAD_GPMI_ALE__GPIO_0_26 |
 +		(MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
++
 +	/* LEDs */
 +	MX28_PAD_SAIF0_LRCLK__GPIO_3_21,
 +	MX28_PAD_SAIF0_MCLK__GPIO_3_20,
 +};
++
 +#define HW_DRAM_CTL29	(0x74 >> 2)
 +#define CS_MAP		0xf
 +#define COLUMN_SIZE	0x2
 +#define ADDR_PINS	0x1
 +#define APREBIT		0xa
++
 +#define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \
 +					ADDR_PINS << 8 | APREBIT)
++
 +void mxs_adjust_memory_params(uint32_t *dram_vals)
 +{
 +	dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
 +}
++
 +void board_init_ll(const uint32_t arg, const uint32_t *resptr)
 +{
 +	mxs_common_spl_init(arg, resptr, iomux_setup, ARRAY_SIZE(iomux_setup));
++
 +	gpio_direction_input(MX28_PAD_LCD_D17__GPIO_1_17);
++
 +	if (gpio_get_value(MX28_PAD_LCD_D17__GPIO_1_17))
 +		mxs_iomux_setup_multiple_pads(iomux_setup_v2, ARRAY_SIZE(iomux_setup_v2));
 +	else
 +		mxs_iomux_setup_multiple_pads(iomux_setup_v1, ARRAY_SIZE(iomux_setup_v1));
 +}
-diff --git a/configs/duckbill_defconfig b/configs/duckbill_defconfig
-new file mode 100644
-index 0000000000..f92a67d53d
 --- /dev/null
 +++ b/configs/duckbill_defconfig
-@@ -0,0 +1,38 @@
+@@ -0,0 +1,31 @@
 +CONFIG_ARM=y
-+CONFIG_ARCH_MX28=y
++CONFIG_TARGET_DUCKBILL=y
-+CONFIG_SYS_TEXT_BASE=0x40002000
 +CONFIG_SPL_GPIO_SUPPORT=y
 +CONFIG_SPL_LIBCOMMON_SUPPORT=y
 +CONFIG_SPL_LIBGENERIC_SUPPORT=y
-+CONFIG_TARGET_DUCKBILL=y
 +CONFIG_SPL_SERIAL_SUPPORT=y
-+CONFIG_SPL=y
-+CONFIG_NR_DRAM_BANKS=1
 +CONFIG_BOOTDELAY=1
++# CONFIG_CONSOLE_MUX is not set
 +CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 +CONFIG_VERSION_VARIABLE=y
 +# CONFIG_DISPLAY_BOARDINFO is not set
++# CONFIG_EFI_LOADER is not set
 +CONFIG_ARCH_MISC_INIT=y
-+# CONFIG_SPL_FRAMEWORK is not set
++CONFIG_SPL=y
 +CONFIG_HUSH_PARSER=y
 +CONFIG_CMD_BOOTZ=y
-+# CONFIG_CMD_ELF is not set
++# CONFIG_CMD_IMLS is not set
-+CONFIG_CMD_UNZIP=y
 +# CONFIG_CMD_FLASH is not set
-+CONFIG_CMD_FUSE=y
-+CONFIG_CMD_GPIO=y
 +CONFIG_CMD_MMC=y
-+CONFIG_CMD_MMC_SWRITE=y
++CONFIG_CMD_GPIO=y
 +CONFIG_CMD_DHCP=y
 +CONFIG_CMD_MII=y
 +CONFIG_CMD_PING=y
++CONFIG_CMD_CACHE=y
 +CONFIG_CMD_EXT4=y
 +CONFIG_CMD_EXT4_WRITE=y
++CONFIG_CMD_FAT=y
 +CONFIG_CMD_FS_GENERIC=y
-+CONFIG_DOS_PARTITION=y
 +CONFIG_ENV_IS_IN_MMC=y
 +CONFIG_MMC_MXS=y
-+CONFIG_MII=y
-+CONFIG_CONS_INDEX=0
 +CONFIG_OF_LIBFDT=y
-+# CONFIG_EFI_LOADER is not set
-diff --git a/include/configs/duckbill.h b/include/configs/duckbill.h
-new file mode 100644
-index 0000000000..e7fce8843e
 --- /dev/null
 +++ b/include/configs/duckbill.h
-@@ -0,0 +1,179 @@
+@@ -0,0 +1,199 @@
-+/* SPDX-License-Identifier: GPL-2.0+ */
 +/*
-+ * Copyright (C) 2014-2019 Michael Heimpold <mhei@heimpold.de>
++ * Copyright (C) 2014-2015 Michael Heimpold <mhei@heimpold.de>
 + *
++ * SPDX-License-Identifier:	GPL-2.0+
 + */
 +#ifndef __CONFIGS_DUCKBILL_H__
 +#define __CONFIGS_DUCKBILL_H__
++
 +/* System configurations */
++#define CONFIG_MX28				/* i.MX28 SoC */
 +#define CONFIG_MACH_TYPE	MACH_TYPE_DUCKBILL
++
 +#define CONFIG_MISC_INIT_R
++
 +#define CONFIG_SYS_MXS_VDD5V_ONLY
++
++/* U-Boot Commands */
++#define CONFIG_CMD_FUSE
++#define CONFIG_CMD_UNZIP
++
 +/* Memory configuration */
++#define CONFIG_NR_DRAM_BANKS		1		/* 1 bank of DRAM */
 +#define PHYS_SDRAM_1			0x40000000	/* Base address */
 +#define PHYS_SDRAM_1_SIZE		0x40000000	/* Max 1 GB RAM */
 +#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
++
 +/* Environment is in MMC */
 +#define CONFIG_ENV_OVERWRITE
 +#define CONFIG_ENV_SIZE			(128 * 1024)
 +#define CONFIG_ENV_OFFSET		(128 * 1024)
 +#define CONFIG_ENV_OFFSET_REDUND	(256 * 1024)
 +#define CONFIG_SYS_MMC_ENV_DEV		0
 +#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
++
 +/* FEC Ethernet on SoC */
-+#ifdef CONFIG_CMD_NET
++#ifdef	CONFIG_CMD_NET
 +#define CONFIG_FEC_MXC
++#define CONFIG_NET_MULTI
 +#define CONFIG_MX28_FEC_MAC_IN_OCOTP
++#define CONFIG_FEC_MXC_PHYADDR	1
-+#define CONFIG_FEC_MXC_MDIO_BASE	MXS_ENET0_BASE
++#define IMX_FEC_BASE		MXS_ENET0_BASE
 +#endif
++
 +#define CONFIG_IPADDR		192.168.1.10
 +#define CONFIG_SERVERIP		192.168.1.1
 +#define CONFIG_NETMASK		255.255.255.0
 +#define CONFIG_GATEWAYIP	192.168.1.254
++
++/* BOOTP options */
++#define CONFIG_BOOTP_SUBNETMASK
++#define CONFIG_BOOTP_GATEWAY
++#define CONFIG_BOOTP_HOSTNAME
++
++/* SPI */
++#ifdef CONFIG_CMD_SPI
++#define CONFIG_DEFAULT_SPI_BUS		2
++#define CONFIG_DEFAULT_SPI_MODE		SPI_MODE_0
++#endif
++
 +/* Boot Linux */
 +#define CONFIG_BOOTDELAY	1
 +#define CONFIG_BOOTFILE		"zImage"
 +#define CONFIG_LOADADDR		0x42000000
 +#define CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR
 +#define CONFIG_REVISION_TAG
 +#define CONFIG_SERIAL_TAG
 +#define CONFIG_OF_BOARD_SETUP
 +#define CONFIG_BOOT_RETRY_TIME		120	/* retry autoboot after 120 seconds */
 +#define CONFIG_AUTOBOOT_KEYED
 +#define CONFIG_AUTOBOOT_PROMPT		"Autobooting in %d seconds, " \
 +					"press <c> to stop\n"
 +#define CONFIG_AUTOBOOT_DELAY_STR	"\x63"	/* allows retry after retry time */
 +#define CONFIG_AUTOBOOT_STOP_STR	" "	/* stop autoboot with <Space> */
 +#define CONFIG_RESET_TO_RETRY			/* reset board to retry booting */
++
 +/* Extra Environment */
 +#define CONFIG_EXTRA_ENV_SETTINGS \
 +	"mmc_part2_offset=1000\0" \
 +	"mmc_part3_offset=19000\0" \
 +	"update_openwrt_firmware_filename=openwrt-mxs-root.ext4\0" \
 +	"update_openwrt_firmware=" \
 +		"if mmc rescan; then " \
 +			"if tftp ${update_openwrt_firmware_filename}; then " \
 +				"setexpr fw_sz ${filesize} + 1ff; " \
 +				"setexpr fw_sz ${fw_sz} / 200; " \
 +				"mmc write ${loadaddr} ${mmc_part2_offset} ${fw_sz}; " \
 +				"mmc write ${loadaddr} ${mmc_part3_offset} ${fw_sz}; " \
 +			"fi; " \
 +		"fi\0" \
 +	"update_fw_filename_prefix=emmc.img.\0" \
 +	"update_fw_filename_suffix=.gz\0" \
 +	"update_fw_parts=0x6\0" \
 +	"update_fw_fsize_uncompressed=4000000\0" \
 +	"gzwrite_wbuf=100000\0" \
 +	"update_emmc_firmware=" \
 +		"setexpr i ${update_fw_parts}; setexpr error 0; " \
 +		"while itest ${i} -gt 0; do " \
 +			"echo Transfering firmware image part ${i} of ${update_fw_parts}; " \
-+			"if itest ${i} -le f; then " \
++			"if itest ${i} -le 9; then " \
 +				"setenv j 0${i}; " \
 +			"else " \
 +				"setenv j ${i}; " \
 +			"fi; " \
 +			"if tftp ${loadaddr} ${update_fw_basedir}${update_fw_filename_prefix}${j}${update_fw_filename_suffix}; then " \
 +				"setexpr k ${i} - 1; " \
 +				"setexpr offset ${update_fw_fsize_uncompressed} * ${k}; " \
 +				"if gzwrite mmc ${mmcdev} ${loadaddr} ${filesize} ${gzwrite_wbuf} ${offset}; then " \
 +					"setexpr i ${i} - 1; " \
 +				"else " \
 +					"setexpr i 0; " \
 +					"setexpr error 1; " \
 +				"fi; " \
 +			"else " \
 +				"setexpr i 0; " \
 +				"setexpr error 1; " \
 +			"fi; " \
 +		"done; setenv i; setenv j; setenv k; setenv fsize; setenv filesize; setenv offset; " \
 +		"if test ${error} -eq 1; then " \
 +			"echo Firmware Update FAILED; " \
 +		"else " \
 +			"echo Firmware Update OK; " \
 +		"fi; setenv error\0" \
 +	"erase_mmc=mmc erase 0 2\0" \
 +	"erase_env1=mmc erase 100 100\0" \
 +	"erase_env2=mmc erase 200 100\0" \
 +	"image=zImage\0" \
 +	"console=ttyAMA0\0" \
++	"fdt_file=imx28-duckbill-2.dtb\0" \
 +	"fdt_addr=0x41000000\0" \
 +	"boot_fdt=try\0" \
 +	"ip_dyn=yes\0" \
 +	"bootsys=1\0" \
 +	"mmcdev=0\0" \
 +	"mmcpart=2\0" \
 +	"mmcroot=/dev/mmcblk0p2\0" \
 +	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 +		"root=${mmcroot} " \
-+		"rootwait bootsys=${bootsys} panic=1 ${extraargs}\0" \
++		"rootwait bootsys=${bootsys} panic=1\0" \
 +	"loadimage=ext4load mmc ${mmcdev}:${mmcpart} ${loadaddr} /boot/${image}\0" \
 +	"loadfdt=ext4load mmc ${mmcdev}:${mmcpart} ${fdt_addr} /boot/${fdt_file}\0" \
 +	"mmcboot=echo Booting from mmc ...; " \
 +		"setexpr mmcpart 1 + ${bootsys}; " \
 +		"setenv mmcroot /dev/mmcblk0p${mmcpart}; " \
 +		"run mmcargs; " \
 +		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
 +			"if run loadfdt; then " \
 +				"bootz ${loadaddr} - ${fdt_addr}; " \
 +			"else " \
 +				"if test ${boot_fdt} = try; then " \
 +					"bootz; " \
 +				"else " \
 +					"echo WARN: Cannot load the DT; " \
 +				"fi; " \
 +			"fi; " \
 +		"else " \
 +			"bootz; " \
 +		"fi\0" \
 +	"nfsroot=/\0" \
 +	"netargs=setenv bootargs console=${console},${baudrate} " \
 +		"root=/dev/nfs " \
-+		"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp ${extraargs}\0" \
++		"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
 +	"netboot=echo Booting from net ...; " \
 +		"run netargs; "	\
 +		"if test ${ip_dyn} = yes; then " \
 +			"setenv get_cmd dhcp; " \
 +		"else " \
 +			"setenv get_cmd tftp; " \
 +		"fi; " \
 +		"${get_cmd} ${image}; " \
 +		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
 +			"if ${get_cmd} ${fdt_addr} ${fdt_file}; then " \
 +				"bootz ${loadaddr} - ${fdt_addr}; " \
 +			"else " \
 +				"if test ${boot_fdt} = try; then " \
 +					"bootz; " \
 +				"else " \
 +					"echo WARN: Cannot load the DT; " \
 +				"fi;" \
 +			"fi; " \
 +		"else " \
 +			"bootz; " \
 +		"fi\0"
++
 +#define CONFIG_BOOTCOMMAND \
 +	"mmc dev ${mmcdev}; " \
 +	"if mmc rescan; then " \
 +		"if run loadimage; then " \
 +			"run mmcboot; " \
 +		"else " \
 +			"run netboot; " \
 +		"fi; " \
 +	"else " \
 +		"run netboot; " \
 +	"fi"
++
 +/* The rest of the configuration is shared */
 +#include <configs/mxs.h>
++
 +#endif /* __CONFIGS_DUCKBILL_H__ */
---
-.17.1
 Generated by GNU Enscript 1.6.5.90.