OpenWrt – Blame information for rev 1
?pathlinks?
Rev | Author | Line No. | Line |
---|---|---|---|
1 | office | 1 | From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> |
2 | Subject: [PATCH] net: mv643xx_eth: Make TSO disabled by default |
||
3 | |||
4 | Data corruption has been observed to be produced by TSO. For instance, |
||
5 | accessing files on a NFS-server with TSO enabled results in different data |
||
6 | transferred each time. |
||
7 | |||
8 | This has been observed only on Kirkwood platforms, i.e. with the mv643xx_eth |
||
9 | driver. Same tests on platforms using the mvneta ethernet driver have |
||
10 | passed without errors. |
||
11 | |||
12 | Make TSO disabled by default for now, until we can found a proper fix |
||
13 | for the regression. |
||
14 | |||
15 | Fixes: 3ae8f4e0b98 ('net: mv643xx_eth: Implement software TSO') |
||
16 | Reported-by: Slawomir Gajzner <slawomir.gajzner <at> gmail.com> |
||
17 | Reported-by: Julien D'Ascenzio <jdascenzio <at> yahoo.fr> |
||
18 | Signed-off-by: Ezequiel Garcia <ezequiel.garcia <at> free-electrons.com> |
||
19 | --- |
||
20 | --- a/drivers/net/ethernet/marvell/mv643xx_eth.c |
||
21 | +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c |
||
22 | @@ -3200,11 +3200,11 @@ static int mv643xx_eth_probe(struct plat |
||
23 | dev->watchdog_timeo = 2 * HZ; |
||
24 | dev->base_addr = 0; |
||
25 | |||
26 | - dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO; |
||
27 | + dev->features = NETIF_F_SG | NETIF_F_IP_CSUM; |
||
28 | dev->vlan_features = dev->features; |
||
29 | |||
30 | dev->features |= NETIF_F_RXCSUM; |
||
31 | - dev->hw_features = dev->features; |
||
32 | + dev->hw_features = dev->features | NETIF_F_TSO; |
||
33 | |||
34 | dev->priv_flags |= IFF_UNICAST_FLT; |
||
35 | dev->gso_max_segs = MV643XX_MAX_TSO_SEGS; |